Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir
Aaron J. Seigo
aseigo at kde.org
Sun Oct 30 08:03:35 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102989/#review7755
-----------------------------------------------------------
why is a CMakeLists.txt needed? plasmapkg is enough, no?
- Aaron J. Seigo
On Oct. 29, 2011, 4:45 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102989/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2011, 4:45 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> With this patch plasmate can now create a CMakeLists.txt.I haven't discussed the patch with someone but i believe that plasmate needs this feature.
>
> If so,at the publisher there is an install button should i convert it into a combobox in order to add the option to install the project using
> cmake and not only using plasmapkg.Of course this will be an another patch.
>
> thanks in advance
>
>
> Diffs
> -----
>
> startpage.cpp fc00441
> templates/CMakeLists.txt b5f8d2b
> templates/cmakelists e69de29
>
> Diff: http://git.reviewboard.kde.org/r/102989/diff/diff
>
>
> Testing
> -------
>
> the source code is fine,i am not sure about the quality of the CMakeLists.txt file
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111030/cb966ea4/attachment.html>
More information about the Plasma-devel
mailing list