Review Request: picture frame widget - open potd picture
Aaron J. Seigo
aseigo at kde.org
Fri Oct 28 12:56:02 UTC 2011
> On Oct. 28, 2011, 11:05 a.m., Aaron J. Seigo wrote:
> > Ship It!
>
> Greg T wrote:
> cool, but I have no write access...your turn ;)
a few more patches like this one and i'll make sure you have write access ;)
seriously though: if you wish to continue contributing over the longer term (or if you end up doing so anyways ;), it's best to get a commit account ..
thanks for the patch, i'll integrate it right now.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102817/#review7711
-----------------------------------------------------------
On Oct. 28, 2011, 10:20 a.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102817/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2011, 10:20 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hi,
> This fix passes m_currentUrl the correct file path, so the downloaded picture will be opened by the picture viewer (gwenview).
>
>
> This addresses bug 280406.
> http://bugs.kde.org/show_bug.cgi?id=280406
>
>
> Diffs
> -----
>
> applets/frame/slideshow.cpp 116c514
> dataengines/potd/potd.cpp f1b9933
>
> Diff: http://git.reviewboard.kde.org/r/102817/diff/diff
>
>
> Testing
> -------
>
> Bug fixed.
>
>
> Thanks,
>
> Greg T
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111028/95096249/attachment.html>
More information about the Plasma-devel
mailing list