Review Request: Escape Text in Microblogging Post Widget

Aaron J. Seigo aseigo at kde.org
Thu Oct 27 19:08:56 UTC 2011



> On Oct. 26, 2011, 2:51 p.m., Aaron J. Seigo wrote:
> > Ship It!
> 
> David Narváez wrote:
>     What's the commit schema? master then 4.7?

for bugfixes, usually 4.7 branch (or whatever the stable branch is) then a git merge to master if it the module is mergeable (i forget if addons is; it might be like kde-workspace and never had that straightened out) in which case a git cherry-pick will suffice.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102973/#review7661
-----------------------------------------------------------


On Oct. 26, 2011, 1:04 p.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102973/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2011, 1:04 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Cleanup some html entities before inserting text in the post widget.
> 
> 
> Diffs
> -----
> 
>   applets/microblog/postwidget.cpp 08e3ff9 
> 
> Diff: http://git.reviewboard.kde.org/r/102973/diff/diff
> 
> 
> Testing
> -------
> 
> Try denting "I <3 KDE". Before this patch, you should only see "I" in the post widget. This patch cleans "<" as "<" and you should see "I <3 KDE" in the widget.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111027/5e08dbab/attachment.html>


More information about the Plasma-devel mailing list