Review Request: Update UI for settings of "Speak Time" in digital clock.

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102944/#review7603
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Oct. 23, 2011, 1:11 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102944/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 1:11 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> A rewrite of https://git.reviewboard.kde.org/r/102878/ fixes suffixes by rewriting it into "every 2 minutes" rather than "every 2th (or 2nd) minutes" which is far more translatable.
> 
> Also restricts input to a smaller range of sane values. It makes /no/ sense to have something that isn't a factor of 60, as otherwise you get a longer gap between intervals when the hour comes round. This makes it easier for a user to select something sensible. Allowing these as inputs is wrong. As an additional bonus it now reads "Every hour" rather than "60 minutes" which is more intuitive.
> 
> 
> Diffs
> -----
> 
>   libs/plasmaclock/clockapplet.cpp 4f16cb1 
>   libs/plasmaclock/generalConfig.ui aae25c0 
> 
> Diff: http://git.reviewboard.kde.org/r/102944/diff/diff
> 
> 
> Testing
> -------
> 
> Tested that it loads saves correctly. Also tried loading from a config file which had a value not in my combo box. This is an incredibly unlikely setup (which is why I'm changing it). It simply reverts back to being set to "Never" the first time they open the config, allowing them to set something else.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102944/s/314/
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111025/04f746d6/attachment-0001.html>