Review Request: Make the task manager items move in realtime when user manually arranges items

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102833/#review7601
-----------------------------------------------------------

Ship it!


nice improvement :)


plasma/desktop/applets/tasks/taskgroupitem.cpp
<http://git.reviewboard.kde.org/r/102833/#comment6594>

    i wonder what happens here when you drag an entry from one tasks widget to another? :)



plasma/desktop/applets/tasks/taskgroupitem.cpp
<http://git.reviewboard.kde.org/r/102833/#comment6593>

    watch the indentation level :)


- Aaron J. Seigo


On Oct. 11, 2011, 6:19 p.m., Shantanu Tushar Jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102833/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2011, 6:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Right now, if the user sets the Task Manager sorting to "manually", its possible to arrange the task items manually. However, the items move only after the mouse button is released.
> This patch makes the items move dynamically and follow the mouse, this helps to produce a more natural effect. Check the attached video for a demo.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/taskgroupitem.h 7ca95ef 
>   plasma/desktop/applets/tasks/taskgroupitem.cpp 14053d6 
> 
> Diff: http://git.reviewboard.kde.org/r/102833/diff/diff
> 
> 
> Testing
> -------
> 
> Works perfectly in both horizontal and vertical configurations, and multiple rows. I didn't find any side-effects.
> 
> 
> Thanks,
> 
> Shantanu Tushar Jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111025/4df7ff6b/attachment.html>