Review Request: picture frame widget - reduce polling intervall
Aaron J. Seigo
aseigo at kde.org
Tue Oct 25 11:31:26 UTC 2011
> On Oct. 25, 2011, 11:23 a.m., Aaron J. Seigo wrote:
> > the fix is in the wrong place; it is actually in the dataengine where this polling interval is set. and it is indeed set to 2 seconds there! without changing the potd dataengine, the network traffic and some of the cpu usage will persist. so i'm fixing it there. thanks for pointing this issue out with a patch!
fixed in 59b1fe9
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102816/#review7595
-----------------------------------------------------------
On Oct. 10, 2011, 10:24 a.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102816/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2011, 10:24 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Heya,
> This patch adjusts the potd polling intervall to 120 seconds. Previously the frame widget was updating the picture every ~2 seconds which caused quite heavy cpu usage!
>
>
> Diffs
> -----
>
> applets/frame/frame.cpp e5fba08
>
> Diff: http://git.reviewboard.kde.org/r/102816/diff/diff
>
>
> Testing
> -------
>
> good so far
>
>
> Thanks,
>
> Greg T
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111025/32655fc5/attachment.html>
More information about the Plasma-devel
mailing list