Runners and their configuration

[Jan Gerrit Marker]

Thanks for you feedback, Sebastian. I fixed the three runners accordingly:
* Spell Checker and AudioPlayerControl (kdeplasma-addons):
   master: 9599af84312fb051c16690d4a5317592935fb0e2
   backported to KDE/4.7: a2c3873a92e2e18f65ac5b4480a490d2bff52a40
* Kill runner (kde-workspace):
   master: ae5bc95288d4808b85e9ba89ad6957c3fb8e9d4f
   backported to KDE/4.7: 024fe3522fb135cb9feb9c1ef3fad1155f6989bd

I tested all changes successfully.

2011/10/21 Sebastian Kügler <sebas at kde.org>:
> On Friday, October 21, 2011 00:16:04 Jan Gerrit Marker wrote:
>> I'm currently investigating the issue that some runners
>> (AudioPlayerControl, Kill, Spellchecker) do not honor their
>> configuration.
>> It seems that the config() function of AbstractRunner does create a
>> KConfigGroup depending on the X-KDE-PluginInfo-Name which is
>> set in the desktop file. But when creating the KConfigGroup in the
>> code of the configuration interface the runners use another name
>> as the one set for X-KDE-PluginInfo-Name. They use the name which they
>> set objectName of the runner to.
>>
>> So my question is whether I should fix the plugins that they use
>> X-KDE-PluginInfo-Name as the group name in the configuration
>> interface's code (should I set the objectName of the runner to
>> X-KDE-PluginInfo-Name in that case, too?) or whether I should change
>> X-KDE-PluginInfo-Name that it matches objectName (are spaces allowed
>> for that entry?). If I changed the configuration interfaces' code I
>> would probably need to write kconfig_update files, wouldn't I?
>
> I'd say change it to whereever the actual config has been written to, in order
> to not break existing setups (lose their config). I don't know krunner
> internals very well, though.
>
> Cheers,
> --
> sebas
>
> http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>