Review Request: Fix ordinal suffix in plasmaclock configuration page for TTS
Sebastian Kügler
sebas at kde.org
Thu Oct 20 20:02:41 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102878/#review7515
-----------------------------------------------------------
libs/plasmaclock/clockapplet.cpp
<http://git.reviewboard.kde.org/r/102878/#comment6495>
this will only work in english. klocale should have suitable functions.
- Sebastian Kügler
On Oct. 15, 2011, 10:38 p.m., Trever Fischer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102878/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2011, 10:38 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Does pretty much what it says on the tin.
>
> No more strings that say "2th". Fixed to handle 1st, 2nd, 3rd, 282nd, 12th, etc.
>
> Brought up by this reddit thread: http://www.reddit.com/r/linux/comments/ld8ow/really_kde/
>
>
> Diffs
> -----
>
> libs/plasmaclock/clockapplet.h ed6230f
> libs/plasmaclock/clockapplet.cpp 4f16cb1
>
> Diff: http://git.reviewboard.kde.org/r/102878/diff/diff
>
>
> Testing
> -------
>
> Spun the spinbox.
>
>
> Thanks,
>
> Trever Fischer
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111020/a8ced333/attachment.html>
More information about the Plasma-devel
mailing list