Review Request: Workaround Taskbar ghost entries bug

[John Stanley]

Hi,
I submitted a patch which hopefully fixes Bug 
https://bugs.kde.org/show_bug.cgi?id=275469),
which may be related to this issue (see Comment #50). The patch is 
short, so here it is:

--- kde-workspace-4.7.2.old/libs/taskmanager/taskitem.cpp       
2011-05-20 16:32:08.000000000 -0400
+++ kde-workspace-4.7.2.new/libs/taskmanager/taskitem.cpp       
2011-10-14 02:23:33.473139259 -0400
@@ -69,7 +69,6 @@ TaskItem::TaskItem(QObject *parent, Star

  TaskItem::~TaskItem()
  {
-    emit destroyed(this);
      //kDebug();
    /*  if (parentGroup()){
          parentGroup()->remove(this);
@@ -99,7 +98,7 @@ void TaskItem::setTaskPointer(TaskPtr ta
          d->task = task.data();
          connect(task.data(), SIGNAL(changed(::TaskManager::TaskChanges)),
                  this, SIGNAL(changed(::TaskManager::TaskChanges)));
-        connect(task.data(), SIGNAL(destroyed()), this, 
SLOT(deleteLater()));
+        connect(task.data(), SIGNAL(destroyed(QObject*)), this, 
SLOT(taskDestroyed()));
          emit gotTaskPointer();
      }
  }


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111014/3e988db2/attachment.html>