Review Request: Simplify pixmap handling for XEmbed-based systray
Aaron J. Seigo
aseigo at kde.org
Wed Oct 5 09:51:54 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102770/#review7109
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Oct. 4, 2011, 3:31 p.m., Luboš Luňák wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102770/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2011, 3:31 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patches changes systemtray handling of XEmbed-based clients from various Xlib code to plain Qt code. The Xlib code was presumably introduced to handle non-native Qt graphics systems, but that can be somewhat more cleanly handled by forcing Qt to create XPixmap-based QPixmap.
>
>
> Diffs
> -----
>
> plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.h fa47b9b
> plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.cpp 0aa5d96
>
> Diff: http://git.reviewboard.kde.org/r/102770/diff/diff
>
>
> Testing
> -------
>
> Tested with plasma-desktop and licq, with and without compositing enabled, seems to work the same way like without the patch.
>
>
> Thanks,
>
> Luboš Luňák
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/b910b94c/attachment.html>
More information about the Plasma-devel
mailing list