Review Request: Simplify pixmap handling for XEmbed-based systray

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102770/#review7095
-----------------------------------------------------------


thanks for the patch ... :)

the coding style should follow the kdelibs style, but that's a minor thing. mostly just the one question regarding something noted in a code comment:


plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.cpp
<http://git.reviewboard.kde.org/r/102770/#comment6233>

    when you say that the alpha channel is not preserved .. does this mean that icons with translucent areas (e.g. rounded icons) will end up with opaque backgrounds?


- Aaron J. Seigo


On Oct. 4, 2011, 3:31 p.m., Luboš Luňák wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102770/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 3:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patches changes systemtray handling of XEmbed-based clients from various Xlib code to plain Qt code. The Xlib code was presumably introduced to handle non-native Qt graphics systems, but that can be somewhat more cleanly handled by forcing Qt to create XPixmap-based QPixmap.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.h fa47b9b 
>   plasma/generic/applets/systemtray/protocols/fdo/x11embedcontainer.cpp 0aa5d96 
> 
> Diff: http://git.reviewboard.kde.org/r/102770/diff/diff
> 
> 
> Testing
> -------
> 
> Tested with plasma-desktop and licq, with and without compositing enabled, seems to work the same way like without the patch.
> 
> 
> Thanks,
> 
> Luboš Luňák
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/f7b785c9/attachment.html>