Review Request: fix the problem that the text below the selected wallpaper is barely readable if the window is inactive

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102772/#review7093
-----------------------------------------------------------

Ship it!


small fix in code style required, otherwise, good to go.


plasma/generic/wallpapers/image/backgrounddelegate.cpp
<http://git.reviewboard.kde.org/r/102772/#comment6232>

    please adhere to the style guidelines. this should be:
    
    if (..) {
         ...
    } else if (..) {
    
    }
    
    yes, even one liners get braces :)


- Aaron J. Seigo


On Oct. 4, 2011, 8:48 p.m., Ralf Jung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102772/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2011, 8:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch fixes the Plasma incarnation of https://bugs.kde.org/show_bug.cgi?id=253022 : The custom item delegate in the wallpaper selection uses incorrect colours if the window is inactive or disabled.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/wallpapers/image/backgrounddelegate.cpp 8354d99 
> 
> Diff: http://git.reviewboard.kde.org/r/102772/diff/diff
> 
> 
> Testing
> -------
> 
> Compiled and checked whether the colours are fixed.
> 
> 
> Thanks,
> 
> Ralf Jung
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111005/bd7799a7/attachment.html>