Review Request: Add an Inhibit button to the Battery applet

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102757/#review7033
-----------------------------------------------------------

Ship it!


i like the direction of this towards simplicity, predictability and "making good decisions in the software" .. 


plasma/generic/applets/battery/battery.cpp
<http://git.reviewboard.kde.org/r/102757/#comment6203>

    I'd personally make it "Power management enabled:" as this follows the pattern of the rest of the items which start with a noun and allows one to scan the left side quickly: battery, ac, time, power management, screen brightness. "Enabled" as a first word doesn't tell us much ("what is enabled?")


- Aaron J. Seigo


On Oct. 3, 2011, 12:28 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102757/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2011, 12:28 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> As the title says. The feature works, but I'm wondering if we can make it look better. Any suggestions warmly appreciated :)
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/battery/battery.h d696014 
>   plasma/generic/applets/battery/battery.cpp c3a4f58 
> 
> Diff: http://git.reviewboard.kde.org/r/102757/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111003/189f6c2b/attachment.html>