Review Request: Add an Inhibit button to the Battery applet

[Dario Freddi]

> On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote:
> > A few remarks inline. I'm not really happy with it UI wise yet, and I'd like to see a screenshot of it in action. Especially that row of iconitems can already grow quite wide, imagine hibernate and suspend both available, and the whole thing in Russian: you need a wide screen display for it ;)
> > 
> > So needs some work.

Agreed, that's why I submitted this review :P unfortunately I wrongly pushed this commit to master, but well --' Any suggestions on where to place it, considering also the combo box is going to go away?


> On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/battery/battery.cpp, line 588
> > <http://git.reviewboard.kde.org/r/102757/diff/1/?file=37774#file37774line588>
> >
> >     c/p error :)

whoops


> On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/battery/battery.cpp, line 1122
> > <http://git.reviewboard.kde.org/r/102757/diff/1/?file=37774#file37774line1122>
> >
> >     Fishy ... I suspect lots of people going "WTF" when seeing a play/stop button...
> >     
> >     Should probably be something in the same style as the logout/shutdown/suspend/... buttons

Agreed. Suggestions for the icons?


> On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote:
> > plasma/generic/applets/battery/battery.cpp, line 1132
> > <http://git.reviewboard.kde.org/r/102757/diff/1/?file=37774#file37774line1132>
> >
> >     Elsewhere, we use pushbuttons, which communicate better if something's enabled or not. Changing button meaning / text is usually not a very good idea, but having a button pressed or not makes it better visible.

Agreed. I think I missed the widget I should use here: just a standard QPushButton or something plasma-ish?


- Dario


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102757/#review7016
-----------------------------------------------------------


On Oct. 2, 2011, 2:48 p.m., Dario Freddi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102757/
> -----------------------------------------------------------
> 
> (Updated Oct. 2, 2011, 2:48 p.m.)
> 
> 
> Review request for Plasma and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> As the title says. The feature works, but I'm wondering if we can make it look better. Any suggestions warmly appreciated :)
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/battery/battery.h d696014 
>   plasma/generic/applets/battery/battery.cpp c3a4f58 
> 
> Diff: http://git.reviewboard.kde.org/r/102757/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dario Freddi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111003/4850f7d1/attachment-0001.html>