Review Request: Plasmate:images can now be added to projects

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102290/#review8607
-----------------------------------------------------------

Ship it!


there is an issue with the threading implementation, but this is easier to fix than to explain and the fix will serve as a good explanation itself ;) so commit what you have so far and i'll fix it and then you can look at the changes to see how it was done. cheers ...


editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment7279>

    the way to fix this is to render it from resizeEvent and tell the thread what size to make it. it's easier to show than to explain, so if you commit this patch, then i'll make the necessary changes and you can look and see how it was done.



editors/imageviewer/imageviewer.cpp
<http://git.reviewboard.kde.org/r/102290/#comment7278>

    these become unecessary when the size of the image is the size of the widget :)



mainwindow.cpp
<http://git.reviewboard.kde.org/r/102290/#comment7277>

    unecessary; just have the thread scale the image.


- Aaron J. Seigo


On Nov. 29, 2011, 4:42 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102290/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2011, 4:42 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> hello,
> 
> without this patch a user cannot add an image with plasmate.
> 
> reproduce,go to files-images-new,the plasmate will open a text editor instead of a dialog,which(the dialog) is able to open an image.
> 
> With the patch a dialog will open asking for an image.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt e825271 
>   editors/CMakeLists.txt 1feb1ce 
>   editors/editpage.h 7b5dca3 
>   editors/editpage.cpp d4b0082 
>   editors/imageviewer/imageloader.h e69de29 
>   editors/imageviewer/imageloader.cpp e69de29 
>   editors/imageviewer/imageviewer.h e69de29 
>   editors/imageviewer/imageviewer.cpp e69de29 
>   main.cpp 66a7cd8 
>   mainwindow.h 7d89815 
>   mainwindow.cpp 6ea7f0c 
>   packagemodel.cpp 8c0907a 
> 
> Diff: http://git.reviewboard.kde.org/r/102290/diff/diff
> 
> 
> Testing
> -------
> 
> the patch is not ready yet,i have noted some questions.
> Also the plasmate tries to open the image with a text editor.This have to be fixed,but how?Should we make plasmate able to preview images?
> 
> In addition,when you add something in the list of files(using the different options provided by the files qdockwidget) it names it as "new".This has to be fixed and the plasmate has to show the real name of the file.(different request,i just want an approval for this patch).
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111130/73d97947/attachment-0001.html>