Review Request: Fix build of Plasma Marble Globe Wallpaper following API changes in Marble

Bernhard Beschow bbeschow at cs.tu-berlin.de
Sat Nov 26 16:39:10 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103243/#review8484
-----------------------------------------------------------

Ship it!


The patch looks good. Thanks for pointing this out and thanks for fixing! :)

- Bernhard Beschow


On Nov. 26, 2011, 12:48 a.m., Ben Cooksley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103243/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2011, 12:48 a.m.)
> 
> 
> Review request for Marble and Plasma.
> 
> 
> Description
> -------
> 
> This patch fixes the build of the Globe wallpaper in kdeplasma-addons following recent API changes in Marble.
> 
> 
> Diffs
> -----
> 
>   wallpapers/marble/marble.cpp 3cecaae 
> 
> Diff: http://git.reviewboard.kde.org/r/103243/diff/diff
> 
> 
> Testing
> -------
> 
> List of maps still appears to be loaded correctly. Build now succeeds.
> 
> 
> Thanks,
> 
> Ben Cooksley
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111126/d7e077de/attachment.html>


More information about the Plasma-devel mailing list