Review Request: Bug fix for 278765

[Aaron J. Seigo]

> On Nov. 16, 2011, 5 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/applets/tasks/abstracttaskitem.cpp, lines 172-176
> > <http://git.reviewboard.kde.org/r/102304/diff/2/?file=37695#file37695line172>
> >
> >     much simpler is:
> >     
> >     data.setInstantPopup(KWindowSystem::compositingActive());
> >     
> >     it does the same thing after all :)
> 
> Aaron J. Seigo wrote:
>     to increase the timeout for zero to an arbitrary value would require allowing Plasma::ToolTipData to take a timeout. i do not want to see that as it means we'll end up with these "special" timeouts (and higher maintenance and impossible to keep consistency) throughout plasma using code.
>     
>     instead, i'd prefer to see instant popups behave more sanely (a small timeout rather than a zero one, for instance). that code is in Plasma::ToolTipManager and is what should be altered.
> 
> Giorgos Tsiapaliwkas wrote:
>     I updated the diff according to Aaron's advice.
>     
>     So if i understood correctly this patch is ready and the Plasma::ToolTipManager.Is another patch.
>     
>     thanks

yes, the tooltipmanager would be a different patch and would need to happen in the frameworks branch against libplasma2 since it is a new feature and not really a bug fix.


- Aaron J.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102304/#review8236
-----------------------------------------------------------


On Nov. 22, 2011, 7:57 a.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102304/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2011, 7:57 a.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> hello,
> 
> I found a third solution for this bug(Aaron said the other two at tha plasma-devel mailing list).
> 
> 
> This addresses bug 278765.
>     http://bugs.kde.org/show_bug.cgi?id=278765
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/abstracttaskitem.cpp 48ba172 
>   plasma/desktop/applets/tasks/applauncheritem.cpp 4dc24ee 
>   plasma/desktop/applets/tasks/taskgroupitem.cpp d7816d3 
>   plasma/desktop/applets/tasks/windowtaskitem.cpp c4db8c7 
> 
> Diff: http://git.reviewboard.kde.org/r/102304/diff/diff
> 
> 
> Testing
> -------
> 
> compiles fines
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111122/dfffd18c/attachment-0001.html>