Review Request: port dictionary qml to Plasma Components
Marco Martin
notmart at gmail.com
Thu Nov 17 11:34:41 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103143/#review8259
-----------------------------------------------------------
Ship it!
i think it's basically good to go, just modulo the very small thing below
dictionary/package/contents/ui/main.qml
<http://git.reviewboard.kde.org/r/103143/#comment7061>
clearbuttonShown is available again in the textfield api, so it can stay
- Marco Martin
On Nov. 15, 2011, 3:54 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103143/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2011, 3:54 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> i ported the plasmoid to the plasma components and also add an archors property in order to be rendered properly.
>
>
> Diffs
> -----
>
> dictionary/package/contents/ui/main.qml e9cb9fc
>
> Diff: http://git.reviewboard.kde.org/r/103143/diff/diff
>
>
> Testing
> -------
>
> the PlasmaWidget.WebView doesn't expand in all the entire layout of the plasmoid.
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111117/1ce65baf/attachment.html>
More information about the Plasma-devel
mailing list