Review Request: kickoff breadcrumb cursor
Marco Martin
notmart at gmail.com
Wed Nov 16 20:43:31 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103159/#review8242
-----------------------------------------------------------
thanks for the patch :)
i think you can do it in a simpler way (see below)
plasma/desktop/applets/kickoff/ui/launcher.cpp
<http://git.reviewboard.kde.org/r/103159/#comment7038>
you don't need to subclass, just button->setCursor(Qt::PointingHandCursor) here
- Marco Martin
On Nov. 16, 2011, 8:36 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103159/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2011, 8:36 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> aseigo told me to do it. So what would be the right implementation? ;)
>
>
> Diffs
> -----
>
> plasma/desktop/applets/kickoff/CMakeLists.txt 4b0d32a
> plasma/desktop/applets/kickoff/ui/breadcrumb.h PRE-CREATION
> plasma/desktop/applets/kickoff/ui/breadcrumb.cpp PRE-CREATION
> plasma/desktop/applets/kickoff/ui/launcher.cpp a2acb35
>
> Diff: http://git.reviewboard.kde.org/r/103159/diff/diff
>
>
> Testing
> -------
>
> works very nice
>
>
> Thanks,
>
> Greg T
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111116/73ed74a4/attachment.html>
More information about the Plasma-devel
mailing list