Review Request: Microblog QML add a package folder and also modify the CMakeLists.txt

[Giorgos Tsiapaliwkas]

> On Nov. 15, 2011, 4:28 p.m., Marco Martin wrote:
> > why a subdirectory more? this is not used anywhere else

i saw the other plasmoids and all of them have a package subdir,so i thought to make the microblog like the others.no?


- Giorgos


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103144/#review8211
-----------------------------------------------------------


On Nov. 15, 2011, 4:18 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103144/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2011, 4:18 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hello,
> 
> i modified the dir paths in order to be more "common" and also i change a little the CMakeLists.txt in order to be correct
> 
> 
> Diffs
> -----
> 
>   microblog/CMakeLists.txt 3a9d6ec 
>   microblog/contents/code/logic.js 8b0af1f 
>   microblog/contents/config/main.xml 638b308 
>   microblog/contents/ui/BasicComponents/ListItem.qml 4617da1 
>   microblog/contents/ui/BasicComponents/MessageWidget.qml 6f532ee 
>   microblog/contents/ui/BasicComponents/PostingWidget.qml 10600df 
>   microblog/contents/ui/BasicComponents/qmldir 5fe1aad 
>   microblog/contents/ui/ComplexComponents/MessageList.qml 97f3611 
>   microblog/contents/ui/ComplexComponents/qmldir d788304 
>   microblog/contents/ui/MainWidget/MainWidget.qml 94c0315 
>   microblog/contents/ui/MainWidget/qmldir 8134d44 
>   microblog/contents/ui/config.ui e478c44 
>   microblog/contents/ui/main.qml 64b79f0 
>   microblog/metadata.desktop d7a50b3 
>   microblog/package/contents/code/logic.js e69de29 
>   microblog/package/contents/config/main.xml e69de29 
>   microblog/package/contents/ui/BasicComponents/ListItem.qml e69de29 
>   microblog/package/contents/ui/BasicComponents/MessageWidget.qml e69de29 
>   microblog/package/contents/ui/BasicComponents/PostingWidget.qml e69de29 
>   microblog/package/contents/ui/BasicComponents/qmldir e69de29 
>   microblog/package/contents/ui/ComplexComponents/MessageList.qml e69de29 
>   microblog/package/contents/ui/ComplexComponents/qmldir e69de29 
>   microblog/package/contents/ui/MainWidget/MainWidget.qml e69de29 
>   microblog/package/contents/ui/MainWidget/qmldir e69de29 
>   microblog/package/contents/ui/config.ui e69de29 
>   microblog/package/contents/ui/main.qml e69de29 
>   microblog/package/metadata.desktop e69de29 
>   microblog/package/platformcontents/application/generic/images/background.png e69de29 
>   microblog/package/platformcontents/application/generic/images/listitem.svgz e69de29 
>   microblog/package/platformcontents/application/generic/images/shadow.svgz e69de29 
>   microblog/package/platformcontents/application/generic/images/sidebarbackground.png e69de29 
>   microblog/package/platformcontents/application/generic/ui/BasicComponents/ListItem.qml e69de29 
>   microblog/package/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml e69de29 
>   microblog/package/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml e69de29 
>   microblog/package/platformcontents/application/generic/ui/BasicComponents/qmldir e69de29 
>   microblog/package/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml e69de29 
>   microblog/package/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml e69de29 
>   microblog/package/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml e69de29 
>   microblog/package/platformcontents/application/tablet/ui/MainWidget/qmldir e69de29 
>   microblog/platformcontents/application/generic/images/background.png b658f04 
>   microblog/platformcontents/application/generic/images/listitem.svgz 828ba19 
>   microblog/platformcontents/application/generic/images/shadow.svgz a3047e1 
>   microblog/platformcontents/application/generic/images/sidebarbackground.png 81908e2 
>   microblog/platformcontents/application/generic/ui/BasicComponents/ListItem.qml 9bb5bab 
>   microblog/platformcontents/application/generic/ui/BasicComponents/MessageWidget.qml 289c611 
>   microblog/platformcontents/application/generic/ui/BasicComponents/PostingWidget.qml c66b2aa 
>   microblog/platformcontents/application/generic/ui/BasicComponents/qmldir 5fe1aad 
>   microblog/platformcontents/application/tablet/ui/MainWidget/ConfigWidget.qml d6f8a42 
>   microblog/platformcontents/application/tablet/ui/MainWidget/MainWidget.qml 5e98f07 
>   microblog/platformcontents/application/tablet/ui/MainWidget/MessageWidgetDetails.qml 23e7884 
>   microblog/platformcontents/application/tablet/ui/MainWidget/qmldir 798f487 
> 
> Diff: http://git.reviewboard.kde.org/r/103144/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111116/a79c7d79/attachment-0001.html>