Review Request: Don't set Icon if iconName is Empty in ActivityBar

Aaron J. Seigo aseigo at kde.org
Wed Nov 16 08:36:47 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103153/#review8224
-----------------------------------------------------------

Ship it!


Ship It!

- Aaron J. Seigo


On Nov. 16, 2011, 5:51 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103153/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2011, 5:51 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Actually just copying code from ActivityBar::insertContainment(Plasma::Containment *cont) where it is already set this way.
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/activitybar/activitybar.cpp eaefafd 
> 
> Diff: http://git.reviewboard.kde.org/r/103153/diff/diff
> 
> 
> Testing
> -------
> 
> Before this patch, activity names without icon would look a bit flushed right. After this patch the names look centered properly.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111116/b6e7aff3/attachment.html>


More information about the Plasma-devel mailing list