Review Request: Plasmate can create a CMakeLists.txt at $my_plasmoid dir

[Sebastian Kügler]

On Saturday, November 12, 2011 20:31:34 Giorgos Tsiapaliwkas wrote:
> What should i do with this patch?

Please commit it. 

Might be cool to also offer the option to install system-wide, you might need 
to do KAuth magic for that, though. One thing that sometimes strikes me is 
that locally installed packages can override system-wide installed ones, 
leading to confusion. (Assume you've installed org.kde.fooapplet in your 
homedir, then you put it into Git and install it system-wide using CMake. When 
running plasmoidviewer org.kde.fooapplet, you'll get the locally installed 
version, and not the system-wide one, so you might not see your changes. 
That's a different, though related issue, however. Something to think about, 
though. Maybe this case can be made easier (searching KServiceTypeTrader for 
an applet with this name and indicating that there is one might be a good 
start.)

Cheers,
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9