Review Request: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

Aaron J. Seigo aseigo at kde.org
Thu Nov 10 20:28:54 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103101/#review8112
-----------------------------------------------------------



libs/taskmanager/task.h
<http://git.reviewboard.kde.org/r/103101/#comment6974>

    this should be an int?


- Aaron J. Seigo


On Nov. 10, 2011, 3:59 p.m., Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103101/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2011, 3:59 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch adds a groupingstrategy that groups tasks by their tab group, from kwin's window tabbing feature.
> Most of the code in wintabgroupingstrategy is copied from programgroupingstrategy.
> This patch is based on https://git.reviewboard.kde.org/r/103099/ to be included in KDELibs 4.7
> 
> 
> This addresses bug 224690.
>     http://bugs.kde.org/show_bug.cgi?id=224690
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/CMakeLists.txt c3848cf 
>   libs/taskmanager/groupmanager.h 760ddf1 
>   libs/taskmanager/groupmanager.cpp b66c6fa 
>   libs/taskmanager/strategies/wintabgroupingstrategy.h PRE-CREATION 
>   libs/taskmanager/strategies/wintabgroupingstrategy.cpp PRE-CREATION 
>   libs/taskmanager/task.h aa05176 
>   libs/taskmanager/task_x11.cpp 9b7d8cb 
> 
> Diff: http://git.reviewboard.kde.org/r/103101/diff/diff
> 
> 
> Testing
> -------
> 
> Tested without problems so far.
> 
> 
> Thanks,
> 
> Anton Kreuzkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111110/2f14d110/attachment.html>


More information about the Plasma-devel mailing list