Review Request: Screen Locker daemon

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103105/
-----------------------------------------------------------

(Updated Nov. 10, 2011, 12:16 p.m.)


Review request for kwin, Plasma and Oswald Buddenhagen.


Changes
-------

already in the plasma group.


Description
-------

Yes I know it's late in the cycle :-) and yes not everything is implemented yet, but I am confident that I get these things finished today or at least till Beta tagging.

This is the new screenlocker work as discussed on kcd some time ago.

The screen locker is split into two parts:
1. A daemon (ksld) to just lock the screen and grab input
2. An unlock dialog (kscreenunlocker) which is executed as a separate process.
    
In case the unlocker fails/crashes the screen is still locked by
the lock daemon.
    
In case kscreenunlocker crashes or does not succeed, it gets
automatically restarted by the daemon.

Things I still need to do:
* D-Bus integration
* Grace time
* integration of existing screen savers into the QML
* cleanup KRunner
* several more things


Diffs
-----

  CMakeLists.txt 9fa4c10 
  screenlocker/CMakeLists.txt PRE-CREATION 
  screenlocker/kcfg/kscreensaversettings.kcfg PRE-CREATION 
  screenlocker/kcfg/kscreensaversettings.kcfgc PRE-CREATION 
  screenlocker/ksld.desktop PRE-CREATION 
  screenlocker/ksldapp.h PRE-CREATION 
  screenlocker/ksldapp.cpp PRE-CREATION 
  screenlocker/lockwindow.h PRE-CREATION 
  screenlocker/lockwindow.cpp PRE-CREATION 
  screenlocker/main.cpp PRE-CREATION 
  screenlocker/unlocker/CMakeLists.txt PRE-CREATION 
  screenlocker/unlocker/main.cpp PRE-CREATION 
  screenlocker/unlocker/qml/lockscreen.qml PRE-CREATION 
  screenlocker/unlocker/unlockapp.h PRE-CREATION 
  screenlocker/unlocker/unlockapp.cpp PRE-CREATION 
  screenlocker/unlocker/unlocker.h PRE-CREATION 
  screenlocker/unlocker/unlocker.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103105/diff/diff


Testing
-------

* Screen locks
* Screen stays locked if unlocker crasher
* unlocker gets restarted


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111110/2343878f/attachment.html>