Review Request: Add a groupingstrategy to automatically group tasks that are grouped using kwin's windowtabbing

Aaron J. Seigo aseigo at kde.org
Thu Nov 10 11:30:27 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103101/#review8094
-----------------------------------------------------------


other than having to wait on the functionality in kdelibs (or performing the atom check directly in Task instead of relying on NetInfo), i wonder if this couldn't be merged into "Program Grouping" itself so that one does not need to choose between grouping by program or by tab collection. e.g. something along the lines of "group tabbed items together, everything else by program name" might fit the principle of least surprise and require people to do less configuration. thoughts?


libs/taskmanager/strategies/wintabgroupingstrategy.cpp
<http://git.reviewboard.kde.org/r/103101/#comment6957>

    there is no point in doing qobject_casts if the values are never checked. either check the values or use static_casts



libs/taskmanager/strategies/wintabgroupingstrategy.cpp
<http://git.reviewboard.kde.org/r/103101/#comment6961>

    indented too far



libs/taskmanager/strategies/wintabgroupingstrategy.cpp
<http://git.reviewboard.kde.org/r/103101/#comment6958>

    const int



libs/taskmanager/strategies/wintabgroupingstrategy.cpp
<http://git.reviewboard.kde.org/r/103101/#comment6959>

    missing {}



libs/taskmanager/strategies/wintabgroupingstrategy.cpp
<http://git.reviewboard.kde.org/r/103101/#comment6960>

    missing {}


- Aaron J. Seigo


On Nov. 9, 2011, 10:34 p.m., Anton Kreuzkamp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103101/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 10:34 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch adds a groupingstrategy that groups tasks by their tab group, from kwin's window tabbing feature.
> Most of the code in wintabgroupingstrategy is copied from programgroupingstrategy.
> This patch is based on https://git.reviewboard.kde.org/r/103099/ to be included in KDELibs 4.7
> 
> 
> This addresses bug 224690.
>     http://bugs.kde.org/show_bug.cgi?id=224690
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/CMakeLists.txt c3848cf 
>   libs/taskmanager/groupmanager.h 760ddf1 
>   libs/taskmanager/groupmanager.cpp b66c6fa 
>   libs/taskmanager/strategies/wintabgroupingstrategy.h PRE-CREATION 
>   libs/taskmanager/strategies/wintabgroupingstrategy.cpp PRE-CREATION 
>   libs/taskmanager/task.h aa05176 
>   libs/taskmanager/task_x11.cpp 9b7d8cb 
> 
> Diff: http://git.reviewboard.kde.org/r/103101/diff/diff
> 
> 
> Testing
> -------
> 
> Tested without problems so far.
> 
> 
> Thanks,
> 
> Anton Kreuzkamp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111110/441e80e4/attachment-0001.html>


More information about the Plasma-devel mailing list