Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

Sergio Luis Martins iamsergio at gmail.com
Wed Nov 9 20:12:51 UTC 2011



> On Nov. 9, 2011, 10:33 a.m., David Narváez wrote:
> > If there are no more comments against or in favor of this patch, I'm assuming everyone is OK with it so I'll commit this patch.

Ok.

Please add a note in the TODO that we'll need to look at this again when using the kdepimlibs library.


- Sergio Luis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102997/#review8038
-----------------------------------------------------------


On Nov. 8, 2011, 9:14 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102997/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2011, 9:14 a.m.)
> 
> 
> Review request for Plasma and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> Adjust KDateTimes after finding out the type of incidence added. Also adjust KDateTimes after a change in the Calendar TimeSpec.
> 
> 
> This addresses bug 279427.
>     http://bugs.kde.org/show_bug.cgi?id=279427
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/calendar/akonadi/calendar.cpp 67c12e9 
> 
> Diff: http://git.reviewboard.kde.org/r/102997/diff/diff
> 
> 
> Testing
> -------
> 
> 1. Add an event in any timezone distinct from the local timezone (you can do that in KOrganizer)
> 2. Check the start and end times of the event in the calendar
> 
> Not sure how to test changing timezones from Plasma, so proposed patch is based on what I think we should do in such a case.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/77bbcb52/attachment.html>


More information about the Plasma-devel mailing list