Review Request: Make IconTask use Plasma::Theme'd "close" button

[Craig Drummond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103092/#review8056
-----------------------------------------------------------

Ship it!


I'm not 100% sure if I prefer this big X to the close icon, but... I guess it is a plasma widget, therefore should use the plasma theme. So, why not.

- Craig Drummond


On Nov. 9, 2011, 4:33 p.m., Diego Casella wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103092/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 4:33 p.m.)
> 
> 
> Review request for Plasma and Craig Drummond.
> 
> 
> Description
> -------
> 
> Simple patch which makes IconTask look more consistent with Plasma Theme.
> It renders the "close" button using Plasma::Theme, and fallback to the standard window-close icon if nothing better is available :)
> 
> 
> Diffs
> -----
> 
>   applets/icontasks/tooltips/windowpreview.cpp 3e0c865 
> 
> Diff: http://git.reviewboard.kde.org/r/103092/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and works as expected (see pictures below).
> 
> 
> Screenshots
> -----------
> 
> ToolTip with themed "close" button
>   http://git.reviewboard.kde.org/r/103092/s/329/
> ToolTip with default "close" icon
>   http://git.reviewboard.kde.org/r/103092/s/330/
> ToolTip with themed "closed" button, resized
>   http://git.reviewboard.kde.org/r/103092/s/331/
> 
> 
> Thanks,
> 
> Diego Casella
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/fd0d0984/attachment.html>