Review Request: Make IconTask use Plasma::Theme'd "close" button

[Diego Casella]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103092/
-----------------------------------------------------------

(Updated Nov. 9, 2011, 3:56 p.m.)


Review request for Plasma and Craig Drummond.


Changes
-------

According to Aaron's suggestions:
* made svgPath const;
* if() else () reordering;
* Plasma::Svg created in the stack instead of the heap;
* resized the close button.


Description
-------

Simple patch which makes IconTask look more consistent with Plasma Theme.
It renders the "close" button using Plasma::Theme, and fallback to the standard window-close icon if nothing better is available :)


Diffs (updated)
-----

  applets/icontasks/tooltips/windowpreview.cpp 3e0c865 

Diff: http://git.reviewboard.kde.org/r/103092/diff/diff


Testing
-------

Compiles and works as expected (see pictures below).


Screenshots
-----------

ToolTip with themed "close" button
  http://git.reviewboard.kde.org/r/103092/s/329/
ToolTip with default "close" icon
  http://git.reviewboard.kde.org/r/103092/s/330/


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/61cf902f/attachment.html>