Review Request: Make IconTask use Plasma::Theme'd "close" button

Aaron J. Seigo aseigo at kde.org
Wed Nov 9 12:29:34 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103092/
-----------------------------------------------------------

(Updated Nov. 9, 2011, 12:29 p.m.)


Review request for Plasma and Craig Drummond.


Changes
-------

already in the plasma group


Description
-------

Simple patch which makes IconTask look more consistent with Plasma Theme.
It renders the "close" button using Plasma::Theme, and fallback to the standard window-close icon if nothing better is available :)


Diffs
-----

  applets/icontasks/tooltips/windowpreview.cpp 3e0c865 

Diff: http://git.reviewboard.kde.org/r/103092/diff/diff


Testing
-------

Compiles and works as expected (see pictures below).


Screenshots
-----------

ToolTip with themed "close" button
  http://git.reviewboard.kde.org/r/103092/s/329/
ToolTip with default "close" icon
  http://git.reviewboard.kde.org/r/103092/s/330/


Thanks,

Diego Casella

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/566debce/attachment.html>


More information about the Plasma-devel mailing list