Review Request: Plasmate:add a new label at the startpage

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102991/#review8040
-----------------------------------------------------------



startpage.cpp
<http://git.reviewboard.kde.org/r/102991/#comment6927>

    uneeded branch as it is the same as the else branch



startpage.ui
<http://git.reviewboard.kde.org/r/102991/#comment6928>

    I would probably write this as:
    
    This is not a valid Plasma Package. Both a metadata.desktop file and a contents/ directory are required. For more information see <link to Plasma Package information on techbase>.
    
    note that "plasmagic" really should not be shown to the user. it's not a term used anywhere in user-facing text.


- Aaron J. Seigo


On Oct. 29, 2011, 4:51 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102991/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2011, 4:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Hi,
> 
> in order someone to load a project using the plasmate,he has to give a path like this,"$my_plasmoid/$my_plasmoid/contents".
> If someone wasn't aware of that he would have an issue.So i add a label which will inform the user about that.
> 
> thanks in advance
> 
> 
> Diffs
> -----
> 
>   startpage.cpp fc00441 
>   startpage.ui 942e6ab 
> 
> Diff: http://git.reviewboard.kde.org/r/102991/diff/diff
> 
> 
> Testing
> -------
> 
> it's ok
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliwkas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111109/b075ad93/attachment.html>