Review Request: KMenuEdit: Decrease icon size in the General tab to make the icon button look like a button

[Hans Chen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103051/
-----------------------------------------------------------

(Updated Nov. 5, 2011, 12:03 a.m.)


Review request for Plasma.


Description
-------

Decrease the KIconButton icon size in KMenuEdit to allow the button to draw a border.

The issue is that without a border, it's not clear that you can click on the icon to change it. This is especially true for new entries that don't have an icon at all (currently it just shows a gray empty space). This patch makes the icon button more similar to the one in the properties dialog of Dolphin.


Diffs
-----

  kmenuedit/basictab.cpp 4953786 

Diff: http://git.reviewboard.kde.org/r/103051/diff/diff


Testing
-------

Tested in trunk/master with the default Oxygen style.


Screenshots
-----------

Difference: Before vs After
  http://git.reviewboard.kde.org/r/103051/s/323/


Thanks,

Hans Chen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111105/dce15ef6/attachment.html>