Review Request: TaskManager: Lock launchers

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103048/#review7964
-----------------------------------------------------------

Ship it!


while it could mostly go into the applet, it is nice that it can be enforced in the library ... just a couple minor issues to address (see comments below) and this can go in...


libs/taskmanager/groupmanager.h
<http://git.reviewboard.kde.org/r/103048/#comment6847>

    these should not be implemented in the header, since that means changes to the implementation requires rebuilding anything that links against it to get the new implementation (!)
    
    and perhaps setLaunchersLocked(bool) should simply become a slot?



libs/taskmanager/groupmanager.cpp
<http://git.reviewboard.kde.org/r/103048/#comment6848>

    the cost of setting the boolean is so low, there's no real need to check for innequality here.


- Aaron J. Seigo


On Nov. 4, 2011, 11:12 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103048/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2011, 11:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add a lockLauncher setting, to prevent users from accidentally moving launchers.
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/groupmanager.h 90a27d2 
>   libs/taskmanager/groupmanager.cpp 15118f0 
>   libs/taskmanager/taskactions.cpp fd69db1 
> 
> Diff: http://git.reviewboard.kde.org/r/103048/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111105/4bdbe057/attachment-0001.html>