Review Request: TaskManager: Lock launchers

[Craig Drummond]

> On Nov. 4, 2011, 11:07 p.m., Aaron J. Seigo wrote:
> > this seems heavy handed and in the wrong place: it should be managed by the visualization whether or not these things are locked. i'm somewhat ok with the idea of having a flag for this in the GroupManager, but i don't think it should be saved to any configuration as that will lead to synchronization issues between the visualization and the GroupManager. already as it is, GroupManagerPrivate::readLauncherConfig setting the flag from the config will prevent further calls made in GroupManager::readLauncherConfig from working and it will fail on the second time it is called.
> > 
> > so ... maybe yes to the flag, but no to saving it in the config by libtaskmanager. that belongs to the visualization for sure.

OK, no probs. I would have put it all in the applet - but I needed access to the lock state in the ToggleLauncher action.


- Craig


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103048/#review7960
-----------------------------------------------------------


On Nov. 4, 2011, 10:46 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103048/
> -----------------------------------------------------------
> 
> (Updated Nov. 4, 2011, 10:46 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Add a lockLauncher setting, to prevent users from accidentally moving launchers.
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/groupmanager.h 90a27d2 
>   libs/taskmanager/groupmanager.cpp 15118f0 
>   libs/taskmanager/taskactions.cpp fd69db1 
> 
> Diff: http://git.reviewboard.kde.org/r/103048/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111104/5286521e/attachment.html>