Review Request: TaskManager: Add routine to detect if item is associated with a launcher.
Aaron J. Seigo
aseigo at kde.org
Fri Nov 4 22:58:10 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103047/#review7958
-----------------------------------------------------------
Ship it!
one small issue, then it can go in.
libs/taskmanager/groupmanager.h
<http://git.reviewboard.kde.org/r/103047/#comment6845>
should be isItemAssociatedWithLauncher
(note both the "itemIs" becomes "isItem" and "with" becomes "With")
- Aaron J. Seigo
On Nov. 4, 2011, 10:45 p.m., Craig Drummond wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103047/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2011, 10:45 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Add a simple function to determine if an item is associated with a launcher.
>
>
> Diffs
> -----
>
> libs/taskmanager/groupmanager.h 90a27d2
> libs/taskmanager/groupmanager.cpp 15118f0
> libs/taskmanager/launcheritem.h df65d2f
> libs/taskmanager/launcheritem.cpp 4621860
>
> Diff: http://git.reviewboard.kde.org/r/103047/diff/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Craig Drummond
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111104/b8ac91c5/attachment.html>
More information about the Plasma-devel
mailing list