Review Request: TaskManager: Pass GroupManager to LauncherItem::shouldShow

[Craig Drummond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103050/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Pass GroupManager instance into shouldShow - as launcher may not always be in a group.

When a launcher is activated, LauncherItem::associateItemIfMatches() emits associateChanged() so that it gets hidden. This show() is connected to GroupManagerPrivate::launcherVisibilityChange(), which in turn calls "rootGroups[currentActivity][currentDesktop]->remove(launcher)" if launcher should not be shown. So now, the launcher is removed from the root group - hence is not in any group. Therefore, when GroupManagerPrivate::currentActivityChanged() calls
LauncherItem::shouldShow(), the launcher has no group - so cannot access groupmanager.


Diffs
-----

  libs/taskmanager/groupmanager.cpp 15118f0 
  libs/taskmanager/launcheritem.h df65d2f 
  libs/taskmanager/launcheritem.cpp 4621860 

Diff: http://git.reviewboard.kde.org/r/103050/diff/diff


Testing
-------


Thanks,

Craig Drummond

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111104/5bc7d546/attachment.html>