Review Request: TaskManager: Watch fir window class changes

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103043/#review7954
-----------------------------------------------------------

Ship it!


i don't think resetLauncherCheck should be a virtual in the base class, but a normal method in TaskItem since it makes no sense in other types. GroupManager even checks for the type before calling it :)

otherwise, this can go in


libs/taskmanager/groupmanager.cpp
<http://git.reviewboard.kde.org/r/103043/#comment6842>

    whitespace :)



libs/taskmanager/groupmanager.cpp
<http://git.reviewboard.kde.org/r/103043/#comment6843>

    using a static_cast to TaskItem here would prevent the need for another purpose-specific virtual in the base class.


- Aaron J. Seigo


On Nov. 3, 2011, 8:41 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103043/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 8:41 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Watch for when a window changes its class, as may have to redetermine launcher. This happens with LibreOffice when it is started by clicking on a document.
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/abstractgroupableitem.h 2f495fc 
>   libs/taskmanager/groupmanager.cpp 6e7ffa7 
>   libs/taskmanager/task.cpp 5dfbea9 
>   libs/taskmanager/task_p.h d0b088e 
>   libs/taskmanager/taskmanager.h 057510c 
> 
> Diff: http://git.reviewboard.kde.org/r/103043/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111104/46f81b9c/attachment-0001.html>