Review Request: Checking the return value of gps_open() as condition instead of checking m_gpsdata for prevent crash when no gpsd running

[Max Lin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103035/
-----------------------------------------------------------

Review request for Plasma.


Description
-------

Checking the return value of gps_open() as condition instead of checking m_gpsdata for GPSD_API_MAJOR_VERSION >=5, there should be prevent crash occurred when no gpsd running. Since m_gpsdata is instanced, there will be always consider gpsd found when no gpsd running, there should be check return value of gps_open() is not -1.


This addresses bug 277036.
    http://bugs.kde.org/show_bug.cgi?id=277036


Diffs
-----

  plasma/generic/dataengines/geolocation/location_gps.cpp 709321b 

Diff: http://git.reviewboard.kde.org/r/103035/diff/diff


Testing
-------

Testing this patch with gpsd 2.96(GPSD_API_MAJOR_VERSION >=5) on trunk and openSUSE Factory, it works and some plasmoids(weather, weatherstation..) which with gpsd support are not crash anymore. However, unfortunately, I have no real gps device to test the function with gps device plugged, but I think this patch should be no broken somewhere with gps device plugged.


Thanks,

Max Lin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111103/0e7eb1d5/attachment.html>