Review Request: TaskManager: Store launcher order

[Craig Drummond]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103006/
-----------------------------------------------------------

(Updated Nov. 2, 2011, 10:04 p.m.)


Review request for Plasma.


Changes
-------

1. Only store launchers in 1 container - not a hash for the launcher items, and a list for sort order.
2. In alphasorting strategy, use if/else and not terinary to make more readable
3. Add a 'forceGrouping' setting, so that applet can decide if items should *always* be grouped.


Description
-------

1. Store the order in which launchers are created
2. Add a new config option, separateLaunchers - so that applet can decide if launchers and tasks should be kept separate.

(Part of IconTasks' taskmanager changes)


Diffs (updated)
-----

  libs/taskmanager/launcheritem.cpp 20f0e7c 
  libs/taskmanager/strategies/alphasortingstrategy.cpp 9ec1aca 
  libs/taskmanager/strategies/desktopsortingstrategy.cpp 520fead 
  libs/taskmanager/abstractgroupingstrategy.cpp 4ed424a 
  libs/taskmanager/abstractsortingstrategy.cpp 390f6f0 
  libs/taskmanager/groupmanager.h acaa142 
  libs/taskmanager/groupmanager.cpp 6e7ffa7 
  libs/taskmanager/strategies/manualsortingstrategy.h 113faab 
  libs/taskmanager/strategies/manualsortingstrategy.cpp 4409a6b 
  libs/taskmanager/strategies/programgroupingstrategy.cpp 5c43d03 
  libs/taskmanager/taskgroup.h 53c2871 
  libs/taskmanager/taskgroup.cpp 49140ae 
  libs/taskmanager/taskitem.h 5de8478 
  libs/taskmanager/taskitem.cpp 0a768e5 

Diff: http://git.reviewboard.kde.org/r/103006/diff/diff


Testing
-------


Thanks,

Craig Drummond

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111102/763be476/attachment.html>