Review Request: TaskManager: Store launcher order

[Craig Drummond]

> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/strategies/desktopsortingstrategy.cpp, line 40
> > <http://git.reviewboard.kde.org/r/103006/diff/1/?file=39936#file39936line40>
> >
> >     this should be a private member of the class ... as this is a non-exported class, binary compatibility doesn't matter.

separateLaunchers is used in the static lessThan() function. So it makes no sense to place it in the class - will not be used elsewhere.


> On Nov. 1, 2011, 2:56 p.m., Aaron J. Seigo wrote:
> > libs/taskmanager/strategies/programgroupingstrategy.cpp, lines 69-73
> > <http://git.reviewboard.kde.org/r/103006/diff/1/?file=39939#file39939line69>
> >
> >     this check looks inccorect: if launchers are integrated or separate, it should still be possible to say that a given application should not be groupable with other windows from that same application.

The another flag will have to be added to GroupManager - as for an icon only taskbar, it makes no sense to split the group.


- Craig


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103006/#review7798
-----------------------------------------------------------


On Oct. 31, 2011, 8:42 p.m., Craig Drummond wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103006/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 8:42 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> 1. Store the order in which launchers are created
> 2. Add a new config option, separateLaunchers - so that applet can decide if launchers and tasks should be kept separate.
> 
> (Part of IconTasks' taskmanager changes)
> 
> 
> Diffs
> -----
> 
>   libs/taskmanager/abstractgroupingstrategy.cpp 4ed424a 
>   libs/taskmanager/abstractsortingstrategy.cpp 390f6f0 
>   libs/taskmanager/groupmanager.h acaa142 
>   libs/taskmanager/groupmanager.cpp 6e7ffa7 
>   libs/taskmanager/launcheritem.cpp 20f0e7c 
>   libs/taskmanager/strategies/alphasortingstrategy.cpp 9ec1aca 
>   libs/taskmanager/strategies/desktopsortingstrategy.cpp 520fead 
>   libs/taskmanager/strategies/manualsortingstrategy.h 113faab 
>   libs/taskmanager/strategies/manualsortingstrategy.cpp 4409a6b 
>   libs/taskmanager/strategies/programgroupingstrategy.cpp 5c43d03 
>   libs/taskmanager/taskgroup.h 53c2871 
>   libs/taskmanager/taskgroup.cpp 49140ae 
>   libs/taskmanager/taskitem.h 5de8478 
>   libs/taskmanager/taskitem.cpp 0a768e5 
> 
> Diff: http://git.reviewboard.kde.org/r/103006/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Craig Drummond
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111102/46722d31/attachment.html>