Review Request: Improved Button.qml in PlasmaComponents

[Mark Gaiser]

> On Nov. 1, 2011, 7:20 p.m., Marco Martin wrote:
> > plasma/declarativeimports/plasmacomponents/qml/Button.qml, line 60
> > <http://git.reviewboard.kde.org/r/103020/diff/1/?file=40072#file40072line60>
> >
> >     width of the buttons should always be the same unless explicitly resized by the client scripts.
> >     reason: cost in terms of amount of pixmap data.
> >     
> >     also, functions to compute size should be as tiny as possible, so -1 on this change

Oke, i will make a one liner from it but the additional pixels have to be added. They are currently just missing making the text really close to icon.


- Mark


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103020/#review7830
-----------------------------------------------------------


On Nov. 1, 2011, 7:01 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103020/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 7:01 p.m.)
> 
> 
> Review request for KDE Runtime, Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> I - quite heavily - modified the Button.qml to just look better. The list of changes:
> - Added myself to the copyright :p
> - Added a second leftMargin to the text if an icon was used. The icon and text where a little to close.
> - Added surfacePressed and renamed surface to surfaceNormal. This is done for a cross fade between 2 images. Works really nice!
> - Added a parallel animation for the cross fade. You just have to test this out! To do so, make a button and press/release it. You will see the fade effect but look carefully since it only lasts 100 milliseconds ;)
> - Removed some - now obsolete - javascript code
> - Fixed the Text{} to use the additional margin space when an icon is used
> 
> For the added animation. This is a crossfade and it looks really nice when you press/release a button.
> 
> 
> Diffs
> -----
> 
>   plasma/declarativeimports/plasmacomponents/qml/Button.qml d7b62d7 
> 
> Diff: http://git.reviewboard.kde.org/r/103020/diff/diff
> 
> 
> Testing
> -------
> 
> Made some buttons and played with them. It all seems to be working just fine.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111101/3bd56e9a/attachment.html>