Review Request: Adjust KDateTimes to Current TimeSpec of the Calendar

Sergio Luis Martins iamsergio at gmail.com
Tue Nov 1 19:39:16 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102997/#review7834
-----------------------------------------------------------


A Calendar object is supposed to mirror what's in akonadi, so we can't change Incidence's timezones in there.

I think this should be resolved in the presentation layer, converting to the local timezone there ( KSystemTimeZones::local() )

- Sergio Luis Martins


On Oct. 31, 2011, 6:57 a.m., David Narváez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102997/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2011, 6:57 a.m.)
> 
> 
> Review request for Plasma and Sergio Luis Martins.
> 
> 
> Description
> -------
> 
> Adjust KDateTimes after finding out the type of incidence added. Also adjust KDateTimes after a change in the Calendar TimeSpec.
> 
> 
> This addresses bug 279427.
>     http://bugs.kde.org/show_bug.cgi?id=279427
> 
> 
> Diffs
> -----
> 
>   plasma/generic/dataengines/calendar/akonadi/calendar.cpp cd96954 
> 
> Diff: http://git.reviewboard.kde.org/r/102997/diff/diff
> 
> 
> Testing
> -------
> 
> 1. Add an event in any timezone distinct from the local timezone (you can do that in KOrganizer)
> 2. Check the start and end times of the event in the calendar
> 
> Not sure how to test changing timezones from Plasma, so proposed patch is based on what I think we should do in such a case.
> 
> 
> Thanks,
> 
> David Narváez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111101/3f975811/attachment.html>


More information about the Plasma-devel mailing list