Review Request: TaskManager: Improve matching of task to launcher (.desktop file)

Craig Drummond craig at kde.org
Tue Nov 1 17:00:52 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103005/
-----------------------------------------------------------

(Updated Nov. 1, 2011, 5 p.m.)


Review request for Plasma.


Changes
-------

1. Allocate KSysGuard::Process on stack
2. Reset launcherUrl in setTaskPointer if the task has changed.


Description
-------

Add more KTrader queries when attempting to match a task to a launcher.

(Part of IconTasks' taskmanager changes)


Diffs (updated)
-----

  libs/taskmanager/CMakeLists.txt 57f5f73 
  libs/taskmanager/startup.h 997eb7e 
  libs/taskmanager/startup.cpp e4df7c7 
  libs/taskmanager/task.h 45acd5a 
  libs/taskmanager/task_win.cpp ea03004 
  libs/taskmanager/task_x11.cpp 04af0c7 
  libs/taskmanager/taskitem.h 5de8478 
  libs/taskmanager/taskitem.cpp 0a768e5 
  libs/taskmanager/taskmanagerrulesrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103005/diff/diff


Testing
-------


Thanks,

Craig Drummond

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20111101/90bff294/attachment-0001.html>


More information about the Plasma-devel mailing list