Review Request: Enable per event icons in KNotify

Aaron J. Seigo aseigo at kde.org
Sun May 29 23:48:22 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101470/#review3583
-----------------------------------------------------------

Ship it!


great; backwards compatible, and forwards looking. commit!

- Aaron J.


On May 29, 2011, 8:44 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101470/
> -----------------------------------------------------------
> 
> (Updated May 29, 2011, 8:44 p.m.)
> 
> 
> Review request for KDE Runtime and Plasma.
> 
> 
> Summary
> -------
> 
> This patch enables to specify different icon for every event in notifyrc file. Example:
>  [Event/telepathyError]
>  IconName=dialog-error
> 
>  [Event/telepathyInfo]
>  IconName=dialog-information
> 
> If there's no such key in [Event/..] section, it looks for the icon in [Global].
> 
> 
> Diffs
> -----
> 
>   knotify/notifybypopup.cpp 36c3039 
> 
> Diff: http://git.reviewboard.kde.org/r/101470/diff
> 
> 
> Testing
> -------
> 
> Testing was done by afiestas at #kde-devel. Works ok.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110529/22626d91/attachment-0001.htm 


More information about the Plasma-devel mailing list