Review Request: The tooltip's tag are mismatch on krandrtray
Max Lin
max7442 at gmail.com
Tue May 24 16:55:07 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101430/
-----------------------------------------------------------
(Updated May 24, 2011, 2:55 p.m.)
Review request for Plasma.
Changes
-------
Modified a bit issue for avoid translation freeze. My mistake.
Summary
-------
After launch krandrtray, move cursor up on krandrtray, it will shows tooltip, however, looks the tag are not match so caused context are not aligned, and text color are not consistent, we also can catch the "tag mismatch" debug message. I added "<tr>" tag to match with "</tr>" tag, after with this patch, the "tag mismatch" message disappear.
Diffs (updated)
-----
kcontrol/randr/krandrtray.cpp aab7295
Diff: http://git.reviewboard.kde.org/r/101430/diff
Testing
-------
Works fine on my openSUSE 11.4 with KDE 4.6.3 , I also attached screenshot before/after with this patch.
Screenshots
-----------
tag mismatch
http://git.reviewboard.kde.org/r/101430/s/172/
tag match
http://git.reviewboard.kde.org/r/101430/s/173/
Thanks,
Max
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110524/b8c99cef/attachment.htm
More information about the Plasma-devel
mailing list