Review Request: Remove Drawbound Move/Resize Functionality

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101411/
-----------------------------------------------------------

Review request for kwin and Plasma.


Summary
-------

This patch removes the drawbound functionality for moving/resizing windows. Drawbound was/is a feature to only render an outline while resizing/moving the window. It was a solution for the case that it is too slow to let the client update all the time and the geometry change is moved to the end of the operation.

With compositing we have for quite some time already the resize effect to replace the drawbound (given that the outline is extremly ugly and IIRC also broken for compositing), so it was only used when using no compositing but makes the code rather complex and did rather ugly things (grabbing X server, using X drawing functionality, requiring an event filter). So I think it is justified to remove this functionality for legacy system. Any objections?

This also removes the possibility for decorations to take over drawbound. Given lxr no decoration is actually using it  (b2 implements the method but the code is ifdefed). I marked the method as deprecated and adjusted the documentation. @Thomas: do you use it in Bespin?

I also removed the options from the KCM. We might consider adding a new option to control the resize effect (though I don't want to touch that code as it doesn't use ui files). I could not remove the rules rows from the rules KCM as my qt-designer currently crashes while starting :-(

Of course this is for when master is open to feature requests.


Adding Plasma as it removes functionality for legacy systems and I want a complete workspace decision.


Diffs
-----

  kwin/activation.cpp b43f6ab 
  kwin/client.h 3b42c29 
  kwin/client.cpp f4988ff 
  kwin/geometry.cpp 499db65 
  kwin/kcmkwin/kwinoptions/windows.h dd2b619 
  kwin/kcmkwin/kwinoptions/windows.cpp 10b7579 
  kwin/kcmkwin/kwinrules/ruleswidget.h 6972e52 
  kwin/kcmkwin/kwinrules/ruleswidget.cpp 300191e 
  kwin/libkdecorations/kdecoration.h 12612bc 
  kwin/options.h 0ef0b92 
  kwin/options.cpp a4cee3c 
  kwin/rules.h 84a8df1 
  kwin/rules.cpp 1587064 
  kwin/useractions.cpp d969def 
  kwin/workspace.h 837e557 

Diff: http://git.reviewboard.kde.org/r/101411/diff


Testing
-------

Resizing/Moving still working with both compositing and no-compositing.


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110521/655e5b0b/attachment.htm