Review Request: Deprecate KLineEdit::clickMessage

[Davide Bettio]

> On May 14, 2011, 4:01 a.m., Shaun Reich wrote:
> > Are you sure the behaviour for the Qt method 100% equivalent to the current? I ask this because now that the deprecated method forwards to it, naturally it's quite important to make sure nothing gets fscked up.
> 
> Nicolas Alvarez wrote:
>     Someone in #kde-devel tried it a little ago. Apparently one of them renders the placeholder text in italics and the other doesn't (don't remember which).
>     
>     (Also, using *both* causes both to draw, one unreadably over the other)
> 
> Aaron J. Seigo wrote:
>     the KDE one does it in italics. and this really should be rendered by the style as it is platform dependent: iirc Mac and KDE does it italics, Windows doesn't.
> 
> Christoph Feck wrote:
>     Right now, the decision whether to use italics is made by the language. The reason is given in the source code.
>     
>     The other issue that I see is that QTextEdit does not support it yet, so there would be an inconsistency if we don't make sure both use the same italics decision and color choice.

I think that we should mark clickMessage as deprecated since now, the italic issue can be fixed in Qt in the meantime.


- Davide


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101360/#review3308
-----------------------------------------------------------


On May 14, 2011, 12:59 a.m., Davide Bettio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101360/
> -----------------------------------------------------------
> 
> (Updated May 14, 2011, 12:59 a.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Summary
> -------
> 
> Since Qt 4.7 QLineEdit::setPlaceholderText is available so KLineEdit::clickMessage should be deprecated.
> I kept clickMessage as not deprecated in plasma/widgets/lineedit but now is using placeholderText.
> 
> 
> Diffs
> -----
> 
>   kdeui/widgets/klineedit.h 909d1f7 
>   kdeui/widgets/klineedit.cpp 0dd3690 
>   plasma/widgets/lineedit.cpp 09c0c66 
> 
> Diff: http://git.reviewboard.kde.org/r/101360/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Davide
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110515/d992dd08/attachment.htm