Review Request: plasmate:startpage menu bar added

Giorgos Tsiapaliwkas terietor at gmail.com
Tue May 10 17:08:30 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101310/
-----------------------------------------------------------

(Updated May 10, 2011, 3:08 p.m.)


Review request for Plasma.


Changes
-------

removing "m_central = new CentralContainer(this);" the crash issue was solved.

I tested the new patch and it is working.


Summary
-------

hello,

this patch adds a menu bar for startpage at file.(Go to file->startpage).The actual work is that using the startpage button the user is  able to go back to the startpage from the editor.

Unfortunately,there is a regression.If you go to start page using the startpage button when you will load a project from the recent list you will receive a sigsegment error.I think that the problem is located at the editors/edipage.cpp:line 152 (emit loadEditor(offers, path);).

thank you for your time. 


Diffs (updated)
-----

  mainwindow.h ea78e4d 
  mainwindow.cpp 8d47b09 
  plasmateui.rc 05aa1cd 

Diff: http://git.reviewboard.kde.org/r/101310/diff


Testing
-------

tseting done by me


Thanks,

Giorgos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110510/e6cfa143/attachment.htm 


More information about the Plasma-devel mailing list