Review Request: Add --replace to plasma-desktop

[Ben Cooksley]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101316/#review3220
-----------------------------------------------------------


Does this patch ensure that Plasma will still register as org.kde.plasma-desktop? If not, it should include such capabilities as there are an extensive number of times where commands to stop Plasma Desktop and remove it's configuration have been posted, and switching to KApplication will break these commands.

Further, it will make supporting the various versions of KDE in use harder, as seperate sets of commands will be needed involving more complicated steps for newer versions.

- Ben


On May 8, 2011, 7:43 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101316/
> -----------------------------------------------------------
> 
> (Updated May 8, 2011, 7:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Replaces KUniqueApplication by a KApplication and adds a selection owner for Plasma Shells like the selection owner used by KWin (WMs in general). If plasma-desktop is already running, it is possible to restart with "plasma-desktop --replace". If plasma-desktop is running and you don't add the --replace, it will only yell (like KWin). The same could be added to the other shells like netbook, to easily restart/switch during development. I got the idea from this thread on wm-spec mailinglist: http://mail.gnome.org/archives/wm-spec-list/2011-January/msg00002.html
> 
> Current state: it works, plasma-desktop is replaced, but sometimes the WeatherEngine is causing a crash when exiting the previous one. So it is possible that the change from KUniqueApplication to KApplication is opening Pandora's Box. You decide whether it is worth to spend more time on it.
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/main.cpp 6f04e98 
>   plasma/desktop/shell/plasmaapp.h 06ee523 
>   plasma/desktop/shell/plasmaapp.cpp 58e8947 
> 
> Diff: http://git.reviewboard.kde.org/r/101316/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110509/c3f67d93/attachment.htm