Review Request: don't launch application two times from plasma's applauncher

Luc Menut lmenut at free.fr
Wed May 4 10:20:56 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101284/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Since last commit to fix bug 262614,
http://commits.kde.org/kde-workspace/abcd170758a32efd8b082bacb5918ee4a6ac05ea in KDE/4.6
http://commits.kde.org/kde-workspace/bedb02e9887ecd9ca429a88e680cc3f138bf2f50 in master
the applications are now launched two times, because the signal is connected two times:
38  connect(m_menu, SIGNAL(triggered(QAction*)), this, SLOT(switchTo(QAction*)));
39  connect(m_menu, SIGNAL(triggered(QAction*)), this, SLOT(switchTo(QAction*)));

removing one of the lines fixes this.


This addresses bug 262614.
    http://bugs.kde.org/show_bug.cgi?id=262614


Diffs
-----

  plasma/generic/containmentactions/applauncher/launch.cpp cbc7175 

Diff: http://git.reviewboard.kde.org/r/101284/diff


Testing
-------

tested on KDE 4.6.2.


Thanks,

Luc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110504/f9363c0f/attachment.htm 


More information about the Plasma-devel mailing list