Review Request: plasmate:startpage menu bar added

[Shaun Reich]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101310/#review3174
-----------------------------------------------------------



mainwindow.h
<http://git.reviewboard.kde.org/r/101310/#comment2708>

    No underscores in method names. Something like showStartPage() would be fine.



mainwindow.cpp
<http://git.reviewboard.kde.org/r/101310/#comment2707>

    "Startpage" -> "Start Page" (2 words)



plasmateui.rc
<http://git.reviewboard.kde.org/r/101310/#comment2709>

    Since this action is under file, to go with the rest it should probably also be file_startpage or so. (just like file_quit, etc.)


- Shaun


On May 6, 2011, 6:36 p.m., Giorgos Tsiapaliwkas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101310/
> -----------------------------------------------------------
> 
> (Updated May 6, 2011, 6:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> hello,
> 
> this patch adds a menu bar for startpage at file.(Go to file->startpage).The actual work is that using the startpage button the user is  able to go back to the startpage from the editor.
> 
> Unfortunately,there is a regression.If you go to start page using the startpage button when you will load a project from the recent list you will receive a sigsegment error.I think that the problem is located at the editors/edipage.cpp:line 152 (emit loadEditor(offers, path);).
> 
> thank you for your time. 
> 
> 
> Diffs
> -----
> 
>   mainwindow.h ea78e4d 
>   mainwindow.cpp bb241a0 
>   plasmateui.rc 05aa1cd 
> 
> Diff: http://git.reviewboard.kde.org/r/101310/diff
> 
> 
> Testing
> -------
> 
> tseting done by me
> 
> 
> Thanks,
> 
> Giorgos
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20110506/485a4f86/attachment-0001.htm